Add advisory for git2: DiffBinaryFile::data() for empty data triggers UB#2981
Open
DanielEScherzer wants to merge 1 commit into
Open
Add advisory for git2: DiffBinaryFile::data() for empty data triggers UB#2981DanielEScherzer wants to merge 1 commit into
DanielEScherzer wants to merge 1 commit into
Conversation
Contributor
Author
|
Date is set as the date of the PR to fix the issue being created Filed pre-emptively with versions CC @weihanglo for maintainer sign off |
DanielEScherzer
force-pushed
the
git2-DiffBinaryFile-data
branch
from
8a4f177 to
97dcca8
Compare
Contributor
Author
locally cloned: somehow I got some weird characters for the |
Member
|
@weihanglo are you planning to release this soon? If so, would prefer to hold off publishing this until a fix has been published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
Links to upstream issue(s) or PR(s)
rust-lang/git2-rs#1278, rust-lang/git2-rs#1279
Severity
Low? Potential UB from misuse of an unsafe function
Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date